feat(community): add mmr search to pgvector #7438
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@jacoblee93 Please take a look when possible. |
jacoblee93
reviewed
Dec 31, 2024
| * @returns Promise that resolves with an array of tuples, each containing a `Document` and its similarity score. | ||
| */ | ||
| async similaritySearchVectorWithScore( | ||
| query: number[], | ||
| k: number, | ||
| filter?: this["FilterType"] | ||
| filter?: this["FilterType"], | ||
| includeEmbedding?: boolean |
There was a problem hiding this comment.
Changing the default signature (even adding params) makes migrations a lot trickier - can we factor this out into a private method?
Sort of like we did with Supabase:
There was a problem hiding this comment.
@jacoblee93 thanks for the review. Have made the suggested changes.
jacoblee93
reviewed
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new features to pgvector class
maxMarginalRelevanceSearchimplementation